Misc: Fix a bunch of code analysis warnings

Some of which were even actual errors.

src/util/audio_stream.cpp

@@ -55,6 +55,7 @@ AudioStream::AudioStream(u32 sample_rate, const AudioStreamParameters& parameter
 
 AudioStream::~AudioStream()
 {
+  StretchDestroy();
   DestroyBuffer();
 }
 

src/util/cd_image_cue.cpp

@@ -86,7 +86,7 @@ bool CDImageCueSheet::OpenAndParse(const char* filename, Error* error)
     if (!track)
       break;
 
-    const std::string track_filename(track->file);
+    const std::string& track_filename = track->file;
     LBA track_start = track->start.ToLBA();
 
     u32 track_file_index = 0;
@@ -124,7 +124,7 @@ bool CDImageCueSheet::OpenAndParse(const char* filename, Error* error)
         return false;
       }
 
-      m_files.push_back(TrackFile{std::move(track_filename), track_fp, 0});
+      m_files.push_back(TrackFile{track_filename, track_fp, 0});
     }
 
     // data type determines the sector size

src/util/cd_subchannel_replacement.cpp

@@ -83,7 +83,7 @@ bool CDSubChannelReplacement::LoadSBI(const std::string& path)
     const u32 lba = MSFToLBA(entry.minute_bcd, entry.second_bcd, entry.frame_bcd);
 
     CDImage::SubChannelQ subq;
-    std::copy_n(entry.data, countof(entry.data), subq.data.data());
+    std::memcpy(subq.data.data(), entry.data, sizeof(entry.data));
 
     // generate an invalid crc by flipping all bits from the valid crc (will never collide)
     const u16 crc = subq.ComputeCRC(subq.data) ^ 0xFFFF;
@@ -119,7 +119,7 @@ bool CDSubChannelReplacement::LoadLSD(const std::string& path)
     const u32 lba = MSFToLBA(entry.minute_bcd, entry.second_bcd, entry.frame_bcd);
 
     CDImage::SubChannelQ subq;
-    std::copy_n(entry.data, countof(entry.data), subq.data.data());
+    std::memcpy(subq.data.data(), entry.data, sizeof(entry.data));
 
     DEBUG_LOG("{:02x}:{:02x}:{:02x}: CRC {}", entry.minute_bcd, entry.second_bcd, entry.frame_bcd,
               subq.IsCRCValid() ? "VALID" : "INVALID");

src/util/cue_parser.cpp

@@ -365,7 +365,7 @@ bool CueParser::File::HandlePregapCommand(const char* line, u32 line_number, Err
     return false;
   }
 
-  m_current_track->zero_pregap = std::move(msf);
+  m_current_track->zero_pregap = msf;
   return true;
 }
 

src/util/d3d11_stream_buffer.cpp

@@ -11,11 +11,11 @@
 
 Log_SetChannel(D3D11Device);
 
-D3D11StreamBuffer::D3D11StreamBuffer() : m_size(0), m_position(0)
+D3D11StreamBuffer::D3D11StreamBuffer()
 {
 }
 
-D3D11StreamBuffer::D3D11StreamBuffer(ComPtr<ID3D11Buffer> buffer) : m_buffer(std::move(buffer)), m_position(0)
+D3D11StreamBuffer::D3D11StreamBuffer(ComPtr<ID3D11Buffer> buffer) : m_buffer(std::move(buffer))
 {
   D3D11_BUFFER_DESC desc;
   m_buffer->GetDesc(&desc);

src/util/d3d11_stream_buffer.h

@@ -42,9 +42,9 @@ public:
 
 private:
   ComPtr<ID3D11Buffer> m_buffer;
-  u32 m_size;
-  u32 m_max_size;
-  u32 m_position;
+  u32 m_size = 0;
+  u32 m_max_size = 0;
+  u32 m_position = 0;
   bool m_use_map_no_overwrite = false;
   bool m_mapped = false;
 };

src/util/d3d12_texture.cpp

@@ -753,7 +753,7 @@ std::unique_ptr<GPUSampler> D3D12Device::CreateSampler(const GPUSampler::Config&
   if (!handle)
     return {};
 
-  return std::unique_ptr<GPUSampler>(new D3D12Sampler(std::move(handle)));
+  return std::unique_ptr<GPUSampler>(new D3D12Sampler(handle));
 }
 
 D3D12TextureBuffer::D3D12TextureBuffer(Format format, u32 size_in_elements) : GPUTextureBuffer(format, size_in_elements)

src/util/gpu_device.cpp

@@ -415,7 +415,7 @@ void GPUDevice::OpenShaderCache(std::string_view base_path, u32 version)
   if (m_features.pipeline_cache && !base_path.empty())
   {
     const std::string basename = GetShaderCacheBaseName("pipelines");
-    const std::string filename = Path::Combine(base_path, TinyString::from_format("{}.bin", basename));
+    std::string filename = Path::Combine(base_path, TinyString::from_format("{}.bin", basename));
     if (ReadPipelineCache(filename))
       s_pipeline_cache_path = std::move(filename);
     else

src/util/gpu_device.h

@@ -449,7 +449,7 @@ public:
 protected:
   Format m_format;
   u32 m_size_in_elements;
-  u32 m_current_position;
+  u32 m_current_position = 0;
 };
 
 class GPUDevice

src/util/gpu_framebuffer_manager.h

@@ -136,7 +136,7 @@ template<typename FBOType, FBOType (*FactoryFunc)(GPUTexture* const* rts, u32 nu
          void (*DestroyFunc)(FBOType fbo)>
 void GPUFramebufferManager<FBOType, FactoryFunc, DestroyFunc>::Clear()
 {
-  for (auto it : m_map)
+  for (const auto& it : m_map)
     DestroyFunc(it.second);
   m_map.clear();
 }

src/util/gpu_shader_cache.h

@@ -76,7 +76,7 @@ private:
   CacheIndex m_index;
 
   std::string m_base_filename;
-  u32 m_version;
+  u32 m_version = 0;
 
   std::FILE* m_index_file = nullptr;
   std::FILE* m_blob_file = nullptr;

src/util/input_source.cpp

@@ -75,7 +75,7 @@ std::optional<InputBindingKey> InputSource::ParseGenericControllerKey(InputSourc
     return std::nullopt;
 
   const std::optional<s32> source_index = StringUtil::FromChars<s32>(source.substr(pos));
-  if (source_index.has_value() || source_index.value() < 0)
+  if (!source_index.has_value() || source_index.value() < 0)
     return std::nullopt;
 
   InputBindingKey key = {};

src/util/opengl_texture.cpp

@@ -554,6 +554,7 @@ void OpenGLDevice::CommitRTClearInFB(OpenGLTexture* tex, u32 idx)
       glEnable(GL_SCISSOR_TEST);
       tex->SetState(GPUTexture::State::Dirty);
     }
+    break;
 
     case GPUTexture::State::Dirty:
       break;

src/util/shadergen.cpp

@@ -23,7 +23,7 @@ ShaderGen::ShaderGen(RenderAPI render_api, GPUShaderLanguage shader_language, bo
     m_glsl(shader_language == GPUShaderLanguage::GLSL || shader_language == GPUShaderLanguage::GLSLES ||
            shader_language == GPUShaderLanguage::GLSLVK),
     m_spirv(shader_language == GPUShaderLanguage::GLSLVK), m_supports_dual_source_blend(supports_dual_source_blend),
-    m_supports_framebuffer_fetch(supports_framebuffer_fetch), m_use_glsl_interface_blocks(false)
+    m_supports_framebuffer_fetch(supports_framebuffer_fetch)
 {
   if (m_glsl)
   {

src/util/shadergen.h

@@ -72,8 +72,8 @@ protected:
   bool m_spirv;
   bool m_supports_dual_source_blend;
   bool m_supports_framebuffer_fetch;
-  bool m_use_glsl_interface_blocks;
-  bool m_use_glsl_binding_layout;
+  bool m_use_glsl_interface_blocks = false;
+  bool m_use_glsl_binding_layout = false;
   bool m_has_uniform_buffer = false;
 
   TinyString m_glsl_version_string;