Misc: Fix a bunch of code analysis warnings

Some of which were even actual errors.
2024-08-02 23:56:06 +10:00
parent 4eb3b2a9a7
commit 3a83c4265c
30 changed files with 93 additions and 78 deletions
--- a/src/util/gpu_framebuffer_manager.h
+++ b/src/util/gpu_framebuffer_manager.h
@ -136,7 +136,7 @@ template<typename FBOType, FBOType (*FactoryFunc)(GPUTexture* const* rts, u32 nu
         void (*DestroyFunc)(FBOType fbo)>
 void GPUFramebufferManager<FBOType, FactoryFunc, DestroyFunc>::Clear()
 {
-  for (auto it : m_map)
+  for (const auto& it : m_map)
    DestroyFunc(it.second);
  m_map.clear();
 }