Misc: Pass string_view by value

2024-05-05 20:21:54 +10:00
parent e4d940a476
commit ca3cfbaa99
111 changed files with 543 additions and 542 deletions
--- a/src/util/cd_image_hasher.cpp
+++ b/src/util/cd_image_hasher.cpp
@ -95,7 +95,7 @@ std::string CDImageHasher::HashToString(const Hash& hash)
                     hash[11], hash[12], hash[13], hash[14], hash[15]);
 }

-std::optional<CDImageHasher::Hash> CDImageHasher::HashFromString(const std::string_view& str)
+std::optional<CDImageHasher::Hash> CDImageHasher::HashFromString(std::string_view str)
 {
  auto decoded = StringUtil::DecodeHex(str);
  if (decoded && decoded->size() == std::tuple_size_v<Hash>)